-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shellxquote settings breaking things cryptically #635
Labels
Comments
Thanks for the heads up. I'll look into it when I get a chance. |
Neovim unsets |
janlazo
added a commit
to janlazo/vim-plug
that referenced
this issue
Sep 19, 2017
Close junegunn#635, junegunn#668, junegunn#539 Use a temporary batchfile for :!, system(), and jobs and run it in cmd.exe. This bypasses Vim/Neovim issues in Windows and reduces the need to set more options. Also, s:shellesc_cmd works in a batchfile only. Set shellredir for system() in Windows $SHELL sets the default value of 'shell' (see :h 'shell'). This affects shellredir but cmd.exe requires '>%s 2>&1'.
janlazo
added a commit
to janlazo/vim-plug
that referenced
this issue
Sep 19, 2017
Close junegunn#635 Close junegunn#668 Close junegunn#539 Use a temporary batchfile for :!, system(), and jobs and run it in cmd.exe. This bypasses Vim/Neovim issues in Windows and reduces the need to set more options. Also, s:shellesc_cmd works in a batchfile only. Set shellredir for system() in Windows $SHELL sets the default value of 'shell' (see :h 'shell'). This affects shellredir but cmd.exe requires '>%s 2>&1'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I had an old
shellxquote=""
from way back when it was required to have such odd things for anything at all to work on windows, when dinosaurs roamed the earth.It never caused issues and fixed some, so in my .vimrc it stayed, until today.
Today I decided to drop NeoBundle for Plug, and I was getting cryptic error messages when I attempted to run
PlugUpdate
to see if everything was working:Turns out my
shellxquote
setting was causing it.A quick look says that Windows defaults are sane now, so that's good at least.
Can you add a warning, or a faq item, or a workaround for that?
The text was updated successfully, but these errors were encountered: