-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix warning on non-finite nadir point #64
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #64 +/- ##
==========================================
+ Coverage 96.60% 96.62% +0.02%
==========================================
Files 8 8
Lines 795 801 +6
==========================================
+ Hits 768 774 +6
Misses 27 27
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
KirlikSayin and DominguezRios do not use the nadir point but the anti-ideal point and an "estimation of the nadir point", respectively.
If the Pareto front is bounded, the nadir point (or an estimation of the nadir point) is also bounded. However the anti-ideal might not be.
In both implementations here, the anti-ideal point is computed hence the warning is necessary.
Co-authored-by: Rémi Garcia <[email protected]>
Co-authored-by: Rémi Garcia <[email protected]>
Closes #60
From a quick survey of some papers, it seems that computing the nadir point is non-trivial in the general case of N>2 objectives, so let's just give the user a more detailed warning of what went wrong and what they should do about it.