Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning on non-finite nadir point #64

Merged
merged 4 commits into from
Apr 12, 2023
Merged

Fix warning on non-finite nadir point #64

merged 4 commits into from
Apr 12, 2023

Conversation

odow
Copy link
Member

@odow odow commented Apr 12, 2023

Closes #60

From a quick survey of some papers, it seems that computing the nadir point is non-trivial in the general case of N>2 objectives, so let's just give the user a more detailed warning of what went wrong and what they should do about it.

@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (1b86584) 96.60% compared to head (fd17331) 96.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
+ Coverage   96.60%   96.62%   +0.02%     
==========================================
  Files           8        8              
  Lines         795      801       +6     
==========================================
+ Hits          768      774       +6     
  Misses         27       27              
Impacted Files Coverage Δ
src/MultiObjectiveAlgorithms.jl 93.50% <100.00%> (+0.17%) ⬆️
src/algorithms/DominguezRios.jl 100.00% <100.00%> (ø)
src/algorithms/KirlikSayin.jl 98.29% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@remi-garcia remi-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KirlikSayin and DominguezRios do not use the nadir point but the anti-ideal point and an "estimation of the nadir point", respectively.

If the Pareto front is bounded, the nadir point (or an estimation of the nadir point) is also bounded. However the anti-ideal might not be.

In both implementations here, the anti-ideal point is computed hence the warning is necessary.

odow and others added 2 commits April 13, 2023 10:06
@odow odow merged commit cf1f92e into master Apr 12, 2023
@odow odow deleted the od/warn-finite branch April 12, 2023 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

KirlikSayin with unbounded objectives
2 participants