Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes bug where getBooleanInput is not available #10

Merged
merged 6 commits into from
May 26, 2021
Merged

Fixes bug where getBooleanInput is not available #10

merged 6 commits into from
May 26, 2021

Conversation

retiman
Copy link
Contributor

@retiman retiman commented May 26, 2021

Last PR introduced some bugs.

  • @actions/core needs to be bumped to 1.3.0 to support getBooleanInput.
  • should be trim() and not trim.

Here's the link to a successful check run: https://github.com/retiman/read-file-action/runs/2674226609?check_suite_focus=true

Sorry about about the inconvenience.

@Akhil-Sapaad
Copy link

@juliangruber can you merge this

@juliangruber
Copy link
Owner

@juliangruber can you merge this

chill, this PR is just 4 minutes old :D

@@ -8,7 +8,7 @@ const main = async () => {
const trim = core.getBooleanInput('trim')
let content = await fs.readFile(path, 'utf8')
if (trim) {
content = content.trim
content = content.trim()
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dang how did I miss this

@juliangruber juliangruber merged commit f041d96 into juliangruber:master May 26, 2021
@juliangruber
Copy link
Owner

@Akhil-Sapaad
Copy link

Screenshot 2021-05-26 at 4 23 18 PM

@juliangruber and @retiman please check this issue

@juliangruber
Copy link
Owner

do you have a link to that? it looks like you put trim: trim, not trim: true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants