Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broswerbase integration #859

Merged
merged 1 commit into from
Nov 21, 2024
Merged

fix: broswerbase integration #859

merged 1 commit into from
Nov 21, 2024

Conversation

Vedantsahai18
Copy link
Member

@Vedantsahai18 Vedantsahai18 commented Nov 21, 2024

Important

Fixes create_session in browserbase.py to correctly use browserbase_project_id for DEMO_PROJECT_ID.

  • Behavior:
    • Fixes create_session in browserbase.py to correctly assign project_id from browserbase_project_id when DEMO_PROJECT_ID is used.

This description was created by Ellipsis for 9794352. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 9794352 in 51 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. integrations-service/integrations/utils/integrations/browserbase.py:84
  • Draft comment:
    browserbase_project_id is not defined in this scope. Use setup.browserbase_project_id instead.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable:
    The comment claims that 'browserbase_project_id' is not defined, but it is imported from '...env', which is visible in the provided code. The suggestion to use 'setup.browserbase_project_id' is not valid as 'setup' does not have this attribute. The comment seems incorrect as the current code should work with the imported 'browserbase_project_id'.
    I might be missing some context about the 'setup' object and its attributes, but based on the provided code, 'setup.browserbase_project_id' does not exist. The comment might be assuming something not present in the code.
    Given the imports and the structure of the code, the comment's suggestion does not align with the available attributes and imports. The current code should function correctly with the imported 'browserbase_project_id'.
    The comment is incorrect because 'browserbase_project_id' is defined through imports, and the suggested change is not valid. The comment should be deleted.

Workflow ID: wflow_YSoBf9t960ZEt4Xe


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@Vedantsahai18 Vedantsahai18 merged commit 5f9408f into dev Nov 21, 2024
10 checks passed
@Vedantsahai18 Vedantsahai18 deleted the x/browserbase_fix branch November 21, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: execute_integration doesn't work correctly with browserbase if you use DEMO_PROJECT_ID
1 participant