Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(integration-service): added env file to load the API_KEYS for various integrations #855

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

Vedantsahai18
Copy link
Member

@Vedantsahai18 Vedantsahai18 commented Nov 21, 2024

Important

Add environment variable handling for API keys in integration services using environs.

  • Environment Variables:
    • Add env.py to load API keys and other sensitive data using environs.
    • Update docker-compose.yml to include new environment variables for integrations.
  • Integration Updates:
    • Modify brave.py, browserbase.py, cloudinary.py, email.py, llama_parse.py, spider.py, and weather.py to use environment variables for API keys.
    • Replace hardcoded 'DEMO_API_KEY' and similar placeholders with actual environment variables.
  • Dependencies:
    • Add environs to pyproject.toml for environment variable management.

This description was created by Ellipsis for 65d5c0a. It will automatically update as commits are pushed.

Copy link
Contributor

@standard-input standard-input bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues flagged.
Standard Input can make mistakes. Check important info.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to 65d5c0a in 1 minute and 17 seconds

More details
  • Looked at 277 lines of code in 10 files
  • Skipped 1 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. integrations-service/integrations/utils/integrations/cloudinary.py:37
  • Draft comment:
    Consider adding exception handling for network-related errors during the file download process to ensure robustness.
  • Reason this comment was not posted:
    Comment was not on a valid diff hunk.

Workflow ID: wflow_ERhaTCDUgucr9J3L


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@HamadaSalhab HamadaSalhab merged commit 6ebe65e into dev Nov 21, 2024
10 checks passed
@HamadaSalhab HamadaSalhab deleted the f/load_api_integration branch November 21, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants