Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(agents-api): Convert assertion errors to 422 http errors #837

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

HamadaSalhab
Copy link
Contributor

@HamadaSalhab HamadaSalhab commented Nov 15, 2024

Important

Convert AssertionError to HTTP 422 error in prepare_execution_input.py.

  • Error Handling:
    • Convert AssertionError to HTTP 422 error in prepare_execution_input.py using rewrap_exceptions decorator.

This description was created by Ellipsis for b07f915. It will automatically update as commits are pushed.

@HamadaSalhab HamadaSalhab merged commit e154e37 into dev Nov 15, 2024
12 of 13 checks passed
@HamadaSalhab HamadaSalhab deleted the x/prepare-execution-assertion branch November 15, 2024 13:09
Copy link
Contributor

@standard-input standard-input bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues flagged.
Standard Input can make mistakes. Check important info.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to b07f915 in 35 seconds

More details
  • Looked at 12 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. agents-api/agents_api/models/execution/prepare_execution_input.py:34
  • Draft comment:
    Consider using partialclass(HTTPException, status_code=422) for AssertionError to maintain consistency with other exceptions.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The change in the PR is correct, but the existing code has a potential issue with exception handling.

Workflow ID: wflow_wfhfR2CN2QvlGozg


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant