Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(agents-api): Fix retrying the resource busy errors #834

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

HamadaSalhab
Copy link
Contributor

@HamadaSalhab HamadaSalhab commented Nov 13, 2024

When a retry-decorated function finishes the maximum amount of retries and still throws an error, tenacity throws an error with type RetryError, so I added that to the list of retryable errors


Important

Added RetryError to RETRYABLE_ERROR_TYPES in tasks.py to handle exhausted retry cases.

  • Error Handling:
    • Added RetryError to RETRYABLE_ERROR_TYPES in tasks.py to handle cases where a retry-decorated function exhausts retries and throws this error.

This description was created by Ellipsis for d200077. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to d200077 in 16 seconds

More details
  • Looked at 38 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. agents-api/agents_api/common/exceptions/tasks.py:180
  • Draft comment:
    The removal of the duplicated code in the is_retryable_error function is not mentioned in the PR description. Ensure this change is intentional, as it removes handling for fastapi.exceptions.HTTPException and httpx.HTTPStatusError.
  • Reason this comment was not posted:
    Comment did not seem useful.

Workflow ID: wflow_KugwdJ9oNrJDfBQP


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@HamadaSalhab HamadaSalhab merged commit 28a4702 into dev Nov 14, 2024
14 checks passed
@HamadaSalhab HamadaSalhab deleted the x/retry-resource-busy-error branch November 14, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant