-
Notifications
You must be signed in to change notification settings - Fork 930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(memory-store): add a call to decompress transitions chunks #1184
Conversation
WalkthroughThe PR includes minor changes to the Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts belowEmoji Descriptions:
Interact with the Bot:
|
LGTM 👍 |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 3582645 in 1 minute and 1 seconds
More details
- Looked at
14
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
2
drafted comments based on config settings.
1. memory-store/migrations/000026_transition_cursor.up.sql:3
- Draft comment:
Verify that the call to decompress_chunk(c, true) handles decompression errors properly & that 'show_chunks' returns only compressed chunks. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%
<= threshold50%
The comment is asking the PR author to verify the behavior of a function call and its error handling, which violates the rule against asking the author to confirm or ensure behavior. It does not provide a specific suggestion or point out a clear issue.
2. memory-store/migrations/000026_transition_cursor.up.sql:4
- Draft comment:
If no result is needed, consider using PERFORM (or suppressing output) to avoid clutter. Also, verify that using 'true' (force mode) with decompress_chunk is safe and idempotent. - Reason this comment was not posted:
Confidence changes required:33%
<= threshold50%
None
Workflow ID: wflow_YlzPYEGKHxV6VSYJ
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
EntelligenceAI PR Summary
The update involves adding a step to decompress existing data chunks before turning off compression in the SQL migration script.
Important
Decompresses existing chunks in
transitions
table and updates schema to addscope_id
with constraints in000026_transition_cursor.up.sql
.SELECT decompress_chunk(c, true)
to decompress existing chunks intransitions
table in000026_transition_cursor.up.sql
.transitions
table.scope_id
attribute totransition_cursor
type.scope_id
whereNULL
.scope_id
is notNULL
for future inserts/updates.transitions
table.This description was created by
for 3582645. It will automatically update as commits are pushed.