dev -> main #1047
Merged
dev -> main #1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix(memory-store): fix vector search function
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
CI Failure Feedback 🧐(Checks updated until commit 1e7cd34)
✨ CI feedback usage guide:The CI feedback tool (
In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR: where Configuration options
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 1e7cd34 in 1 minute and 53 seconds
More details
- Looked at
186lines of code in7files - Skipped
0files when reviewing. - Skipped posting
8drafted comments based on config settings.
1. agents-api/agents_api/autogen/Docs.py:153
- Draft comment:
The change in confidence range from 0.0 to -1.0 seems incorrect. Confidence values should logically be between 0 and 1. This change might introduce logical errors in the application. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable:
While traditionally confidence values are often between 0 and 1, in search contexts negative confidence values can be meaningful - they could represent inverse correlations or distance metrics. Since this is a generated file from an OpenAPI spec, the change was likely intentional to support a specific search functionality. Without knowing the search implementation details, we can't definitively say this is wrong.
I might be missing important implementation details about how confidence is used in the search system. The comment author could be right that negative confidences could cause issues.
However, since this is a generated file from an API spec, the change was likely intentional and tested. Without strong evidence of an actual problem, we shouldn't block this change.
Delete the comment since we don't have strong evidence that the change is incorrect, and the change was likely intentional given it's in a generated file.
2. agents-api/agents_api/autogen/Docs.py:222
- Draft comment:
The change in confidence range from 0.0 to -1.0 seems incorrect. Confidence values should logically be between 0 and 1. This change might introduce logical errors in the application. - Reason this comment was not posted:
Marked as duplicate.
3. integrations-service/integrations/autogen/Docs.py:153
- Draft comment:
The change in confidence range from 0.0 to -1.0 seems incorrect. Confidence values should logically be between 0 and 1. This change might introduce logical errors in the application. - Reason this comment was not posted:
Marked as duplicate.
4. integrations-service/integrations/autogen/Docs.py:222
- Draft comment:
The change in confidence range from 0.0 to -1.0 seems incorrect. Confidence values should logically be between 0 and 1. This change might introduce logical errors in the application. - Reason this comment was not posted:
Marked as duplicate.
5. typespec/docs/models.tsp:129
- Draft comment:
The change in confidence range from 0.0 to -1.0 seems incorrect. Confidence values should logically be between 0 and 1. This change might introduce logical errors in the application. - Reason this comment was not posted:
Marked as duplicate.
6. typespec/docs/models.tsp:150
- Draft comment:
The change in confidence range from 0.0 to -1.0 seems incorrect. Confidence values should logically be between 0 and 1. This change might introduce logical errors in the application. - Reason this comment was not posted:
Marked as duplicate.
7. typespec/tsp-output/@typespec/openapi3/openapi-1.0.0.yaml:2987
- Draft comment:
The change in confidence range from 0.0 to -1.0 seems incorrect. Confidence values should logically be between 0 and 1. This change might introduce logical errors in the application. - Reason this comment was not posted:
Marked as duplicate.
8. typespec/tsp-output/@typespec/openapi3/openapi-1.0.0.yaml:3070
- Draft comment:
The change in confidence range from 0.0 to -1.0 seems incorrect. Confidence values should logically be between 0 and 1. This change might introduce logical errors in the application. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_PbcICD3nFRRH9KAy
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Bug fix, Enhancement
Description
Adjusted
confidencerange to allow values from -1 to 1.Updated vector search logic for improved accuracy and flexibility.
Disabled the
translate-readmeGitHub action.Refactored SQL and TypeSpec models for consistency with new
confidencerange.Changes walkthrough 📝
Docs.py
Adjust `confidence` range in API modelsagents-api/agents_api/autogen/Docs.py
confidencerange to allow values from -1 to 1.Docs.py
Adjust `confidence` range in integration modelsintegrations-service/integrations/autogen/Docs.py
confidencerange to allow values from -1 to 1.models.tsp
Update TypeSpec models for new confidence rangetypespec/docs/models.tsp
confidencerange to allow values from -1 to 1.search_docs.py
Minor formatting cleanup in search_docs routeragents-api/agents_api/routers/docs/search_docs.py
translate-readme.yml
Disable translate-readme GitHub action.github/workflows/translate-readme.yml
translate-readmeGitHub action.000022_vector_search.up.sql
Update vector search SQL logic and confidence validationmemory-store/migrations/000022_vector_search.up.sql
confidencerange validation to allow -1 to 1.confidencerange.openapi-1.0.0.yaml
Update OpenAPI spec for new confidence rangetypespec/tsp-output/@typespec/openapi3/openapi-1.0.0.yaml
confidencevalues from -1 to1.
confidence.Important
Adjusted confidence range for document search requests and updated vector search SQL function.
HybridDocSearchRequestandVectorDocSearchRequestinDocs.pyandmodels.tsp.search_by_vectorfunction in000022_vector_search.up.sqlto handle confidence range [-1.0, 1.0] and adjusted search threshold calculation.on.push.pathstrigger intranslate-readme.yml.This description was created by
for 1e7cd34. It will automatically update as commits are pushed.