Add 'Damage' abstraction #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This centralizes functionality in a single abstraction that can be used in all places that handle damage values.
Fixes a off-by-one mistake in fire arrow damage randomization logic that was preventing the final damage from ever being the maximum value of the range. For example, a 1-10 fire damage item would only ever do between 1 and 9 damage.
Will be used in a few places where it is important to make the distinction between fixed and variable damage (i.e. printing values, oil applicaiton, etc).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new Damage struct to abstract damage values (min/max vs constant) and randomization logic in a single place. All methods and models that had a pair of int values now leverage a Damage instance in its place.