Thread through the transaction #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameinel
approved these changes
Feb 27, 2019
There was a problem hiding this comment.
let's pull in the test change from https://github.com/juju/txn/pull/53/files
achilleasa
force-pushed
the
interface-transaction-change
branch
from
742c084 to
ede9ccc
Compare
jameinel
reviewed
Feb 27, 2019
txn.go
Outdated
| // Treat this the same as ErrNoOperations but don't suppress other errors. | ||
| return nil | ||
| } | ||
| if err := tr.RunTransaction(ops); err == nil { | ||
| t.Attempt = i |
There was a problem hiding this comment.
I feel like this might be easier to read, and harder to make a mistake if the Transaction wasn't created until here, as just:
t := Transaction{
Ops: ops,
Attempt: i,
}
And we leave the local vars 'ops' and 'err'.
That way there isn't any chance to accidentally still refer to the old ops in the next trip around the loop.
The following changes are formalising a discussion[1] from a previous PR juju#48, where it might make more sense to pass the ObservedTransaction through. There are a couple of things to note: 1. I renamed ObservedTransaction to Transaction, as it no longer observes the transaction, it's actually used when calling the runner. With this in mind I renamed it as it made more sense. 2. I left the ObservedTransaction as value object rather than a pointer when it is passed to runTransactionObserver so that it implies immutability (even though you can modify the Ops etc). - 1 juju#48 (comment)
achilleasa
force-pushed
the
interface-transaction-change
branch
from
ede9ccc to
3575e81
Compare
jameinel
approved these changes
Feb 27, 2019
achilleasa
force-pushed
the
interface-transaction-change
branch
from
3575e81 to
805c94f
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changes are formalising a discussion[1] from a previous
PR #48, where it might make more sense to pass the ObservedTransaction
through.
There are a couple of things to note:
observes the transaction, it's actually used when calling the
runner. With this in mind I renamed it as it made more sense.
pointer when it is passed to runTransactionObserver so that it
implies immutability (even though you can modify the Ops etc).