When observing transactions include the run Duration. #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets us see both what the transactions are, as well as how long they took to run, and whether or not they errored out. I switched from a func taking particular arguments to a func taking a Struct so that if we come up with more parameters we want to pass, we can do so without breaking the API.
howbazaar
approved these changes
Apr 5, 2018
| @@ -159,6 +176,10 @@ func NewRunner(params RunnerParams) Runner { | |||
| txnRunner.testHooks = make(chan ([]TestHook), 1) | |||
| txnRunner.testHooks <- nil | |||
| txnRunner.newRunner = txnRunner.newRunnerImpl | |||
| txnRunner.clock = params.Clock | |||
| if txnRunner.clock == nil { | |||
There was a problem hiding this comment.
This should be a required param.
txn.go
Outdated
| @@ -226,10 +247,17 @@ func (tr *transactionRunner) RunTransaction(ops []txn.Op) error { | |||
| logger.Infof("transaction 'before' hook end") | |||
| } | |||
| } | |||
| // TODO: Should this be a clock instead? | |||
There was a problem hiding this comment.
Yes it is, can remove this todo now.
Promote the Clock to be mandatory, cleanup a code comment.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us see both what the transactions are, as well as how long
they took to run, and whether or not they errored out.
I switched from a func taking particular arguments to a func taking a
Struct so that if we come up with more parameters we want to pass, we
can do so without breaking the API.