Various cleanups #35
Merged
Various cleanups #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 11, 2017 11:03
In preparation for adding more.
The pruning related functions often took both a mgo.Collection and a mgo.Database. This was unnecessary given that the database can be retrieved from the collection. It is also safer to pass them together given that the collection's database should never be different to the given database.
jameinel
approved these changes
May 15, 2017
| @@ -286,10 +311,11 @@ func txnsPruneC(txnsName string) string { | |||
| // TODO(mjs) - this knows way too much about mgo/txn's internals and | |||
| // with a bit of luck something like this will one day be part of | |||
| // mgo/txn. | |||
| func PruneTxns(db *mgo.Database, oracle Oracle, txns *mgo.Collection, stats *CleanupStats) error { | |||
| func PruneTxns(oracle Oracle, txns *mgo.Collection, stats *CleanupStats) error { | |||
There was a problem hiding this comment.
Do we want to unexport this in preparation for the future?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass CleanAndPrune arguments as a struct
In preparation for adding more.
Avoid unnecessarily passing db around
The pruning related functions often took both a
mgo.Collectionand amgo.Database. This was unnecessary given that the database can beretrieved from the collection. It is also safer to pass them together
given that the collection's database should never be different to the
given database.