Move ConfigureLoggers to the Context struct. #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameinel
approved these changes
May 23, 2019
| err := context.ConfigureLoggers("testing.module=debug") | ||
| c.Assert(err, gc.IsNil) | ||
| expected := "<root>=INFO;testing.module=DEBUG" | ||
| c.Assert(context.Config().String(), gc.Equals, expected) |
There was a problem hiding this comment.
should you be testing that the configured levels actually mean something (eg, debug messages are included for testing.module but not for a different logger?)
I'm slightly worried about user confusion (understanding that each context has its own logger config, etc.) but it does fit the issue we are trying to address (have explicitly different logging config for each model).
There was a problem hiding this comment.
There are other tests that test that the configured loggers output the right levels, so I don't think it is necessary here.
Yes, I think there is the potential for confusion. The docs are pretty clear though.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is good to be able to configure any logging context with a string.