Split up logger.go and writer.go. #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju-loggo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The global logger code is pulled out into global.go. Nothing else in writer.go is pulled out. Other code in logger.go is split out into config.go, level.go and module.go. Test code was also split out. A "loggotest" package is added which duplicates (albeit split up) the code in testwriter.go, which means we can stop using the testing code out of the loggo package.
Note: this patch strictly moves code around and doesn't actually change any code (except for factoring out newLogger() in logger.go); nothing new is added (except for some tests).
(Review request: http://reviews.vapour.ws/r/4812/)