-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace juju run and juju scp with ssh and scp #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnsca
suggested changes
Jul 23, 2019
ff3ce99
to
a43c2ea
Compare
jhobbs
suggested changes
Aug 19, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I have some comments.
jhobbs
approved these changes
Aug 20, 2019
lutostag
reviewed
Aug 20, 2019
machines = {} | ||
juju_status = yaml.load(open('juju_status.yaml', 'r'), | ||
Loader=yaml.FullLoader) | ||
for machine, machine_data in juju_status['machines'].tems(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo here on items
thanks, I will submit a patch immediately
…On Tue, Aug 20, 2019 at 4:41 PM Greg Lutostanski ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In jujucrashdump/crashdump.py
<#43 (comment)>:
> @@ -178,12 +198,27 @@ def __init__(self, model, max_size, extra_dirs, output_dir=None,
self.timeout = timeout
self.journalctl = journalctl
+ def get_all(self):
+ machines = {}
+ juju_status = yaml.load(open('juju_status.yaml', 'r'),
+ Loader=yaml.FullLoader)
+ for machine, machine_data in juju_status['machines'].tems():
typo here on items
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#43?email_source=notifications&email_token=AD6HWQVL7H37SIAJYZHVTNLQFP7DFA5CNFSM4IGDAZE2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCCC7WXA#pullrequestreview-277216092>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AD6HWQUI6PHRELRBVPH4QG3QFP7DFANCNFSM4IGDAZEQ>
.
--
"The mere thought hadn't even begun to speculate about the merest
possibility of crossing my mind."
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When unit is in error or blocked state juju run will not connect.
Using ssh instead allows to collect data regardless of juju agent
status.
solves #28 amd #26