Add methods to retrieve raw bundle string #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack-w-shaw
force-pushed
the
JUJU-5926_add_method_to_retreive_raw_bundle
branch
from
6f7af24 to
6ba7add
Compare
5 tasks
bundle.go
Outdated
| @@ -15,6 +15,8 @@ import ( | |||
| type Bundle interface { | |||
| // Data returns the contents of the bundle's bundle.yaml file. | |||
| Data() *BundleData | |||
| // RawBundle returns the raw string content of a bundle | |||
| RawBundle() string | |||
There was a problem hiding this comment.
I'm struggling to like this name. Maybe BundleBytes()?
There was a problem hiding this comment.
Yeah that's fair
I'll obviously change the return type to []byte as well
Add this BundleBytes method to Bundle interface and BundleDataSource In Juju, we have come across a need to run some extra parsing + verification which we do not want to do in juju/charm. We want to keep the data model clean in juju/charm. As such, we need to way to keep the raw bundle data around for later parsing Add this to BundleDataSource, as this is what we use in Juju However, we also implement our own BundleDataSource in Juju. built with the Bundle interface here. So we need to add this method to Bundle as well
jack-w-shaw
force-pushed
the
JUJU-5926_add_method_to_retreive_raw_bundle
branch
from
6ba7add to
3845e5d
Compare
SimonRichardson
approved these changes
May 21, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add this RawBundle method to Bundle interface and BundleDataSource
In Juju, we have come across a need to run some extra parsing + verification which we do not want to do in juju/charm. We want to keep the data model clean in juju/charm.
As such, we need to way to keep the raw bundle data around for later parsing
Add this to BundleDataSource, as this is what we use in Juju
However, we also implement our own BundleDataSource in Juju. built with the Bundle interface here. So we need to add this method to Bundle as well
You can see a draft implementation for this change here:
juju/juju#17350
As a flyby, delete some incorrect comments
QA Steps
Compile into juju form the following PR and run it's QA steps:
juju/juju#17350