Enable the admin socket and log file for librbd client #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisMacNaughton
previously approved these changes
Aug 28, 2018
Need to sync it on related charm openstack project Related-Bug: LP#1786874
|
looks like cinder-volume use too much rados client. which will generate too much ceph client log file. |
|
maybe I'm wrong, I might have misunderstood about the $pid, maybe the $pid is refer to cinder-volume process, not the thread. I will need to do some experiment. |
|
Ive tried enabling this in my local env on a cinder node. I then created 100 (rbd) volumes and there were 0 logfiles in /var/log/ceph which suggests that librbd does not support client logging. As a side test i ran an rbd cli command and it created /var/log/ceph/client.admin.550767.log. |
|
Two problems
|
lathiat
added a commit
to lathiat/charm-helpers
that referenced
this pull request
May 20, 2021
Enable 'log to syslog' and 'err to stderr' for ceph clients. Currently the default configuration disables "log to syslog" for ceph primarily targeting the ceph OSD units which log to files in /var/log/ceph instead. However this value is also used by ceph clients and as a result even with an error a ceph client such as libvirt/qemu will not log errors *anywhere* making issues such as failure to connect to a ceph cluster or invalid keyrings difficult to diagnose. Hence we always enable 'log to syslog' for ceph clients. We could alternatively enable log to a file, however, there are apparmor and permissions issues that mean access to /var/log/ceph is not guaranteed and in some cases multiple PIDs may write to this file creating many different files so syslog seems like the best choice. (Reference: juju#204) Also enable 'err to stderr' which it makes it more likely the error is surfaced in other important locations such as /var/log/libvirt/qemu/instance-*.log and on the command line. Partial-Bug: #1786874
lathiat
added a commit
to lathiat/charm-helpers
that referenced
this pull request
May 20, 2021
Enable 'log to syslog' and 'err to stderr' for ceph clients. Currently the default configuration disables "log to syslog" for ceph primarily targeting the ceph OSD units which log to files in /var/log/ceph instead. However this value is also used by ceph clients and as a result even with an error a ceph client such as libvirt/qemu will not log errors *anywhere* making issues such as failure to connect to a ceph cluster or invalid keyrings difficult to diagnose. Hence we always enable 'log to syslog' for ceph clients. We could alternatively enable log to a file, however, there are apparmor and permissions issues that mean access to /var/log/ceph is not guaranteed and in some cases multiple PIDs may write to this file creating many different files so syslog seems like the best choice. (Reference: juju#204) Also enable 'err to stderr' which it makes it more likely the error is surfaced in other important locations such as /var/log/libvirt/qemu/instance-*.log and on the command line. Partial-Bug: #1786874
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to sync it on related charm openstack project