Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix parse rsa from pem #1724

Merged
merged 3 commits into from
Apr 6, 2022
Merged

fix parse rsa from pem #1724

merged 3 commits into from
Apr 6, 2022

Conversation

zhijian-pro
Copy link
Contributor

Close #1708

@zhijian-pro zhijian-pro marked this pull request as draft April 6, 2022 03:08
@zhijian-pro zhijian-pro force-pushed the fix_parse_rsa_from_pem branch from cd7ae12 to 972064f Compare April 6, 2022 03:10
@zhijian-pro zhijian-pro marked this pull request as ready for review April 6, 2022 03:14
@zhijian-pro zhijian-pro marked this pull request as draft April 6, 2022 03:28
@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2022

Codecov Report

Merging #1724 (e64be57) into main (8d0ee9f) will decrease coverage by 0.01%.
The diff coverage is 23.80%.

@@            Coverage Diff             @@
##             main    #1724      +/-   ##
==========================================
- Coverage   61.85%   61.84%   -0.02%     
==========================================
  Files         135      135              
  Lines       22876    22907      +31     
==========================================
+ Hits        14151    14166      +15     
- Misses       7134     7151      +17     
+ Partials     1591     1590       -1     
Impacted Files Coverage Δ
cmd/format.go 60.96% <0.00%> (-1.62%) ⬇️
pkg/object/encrypt.go 68.29% <45.45%> (ø)
pkg/chunk/utils_unix.go 73.33% <0.00%> (-20.00%) ⬇️
pkg/fuse/context.go 56.75% <0.00%> (-10.82%) ⬇️
pkg/meta/info.go 85.10% <0.00%> (-1.17%) ⬇️
pkg/vfs/reader.go 84.48% <0.00%> (-0.19%) ⬇️
pkg/object/obs.go 0.96% <0.00%> (-0.03%) ⬇️
pkg/meta/utils.go 71.18% <0.00%> (ø)
pkg/chunk/cached_store.go 80.40% <0.00%> (+0.07%) ⬆️
cmd/mount.go 70.72% <0.00%> (+0.13%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d0ee9f...e64be57. Read the comment docs.

cmd/format.go Show resolved Hide resolved
@davies davies marked this pull request as ready for review April 6, 2022 09:45
@zhijian-pro zhijian-pro requested a review from davies April 6, 2022 09:59
cmd/format.go Outdated Show resolved Hide resolved
@zhijian-pro zhijian-pro requested a review from davies April 6, 2022 11:02
@davies davies merged commit 2026936 into main Apr 6, 2022
@davies davies deleted the fix_parse_rsa_from_pem branch April 6, 2022 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky test: TestRSA
3 participants