sync command support --links #1619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davies
reviewed
Mar 21, 2022
Codecov Report
@@ Coverage Diff @@
## main #1619 +/- ##
==========================================
+ Coverage 61.27% 61.48% +0.21%
==========================================
Files 133 133
Lines 22460 22552 +92
==========================================
+ Hits 13762 13867 +105
+ Misses 7137 7124 -13
Partials 1561 1561
Continue to review full report at Codecov.
|
zhijian-pro
commented
Mar 21, 2022
zhijian-pro
force-pushed
the
support_--links_for_sync
branch
from
388223a to
9a95c41
Compare
davies
reviewed
Mar 21, 2022
davies
reviewed
Mar 21, 2022
davies
reviewed
Mar 22, 2022
zhijian-pro
force-pushed
the
support_--links_for_sync
branch
from
7a4d266 to
5797aa3
Compare
sjp00556
reviewed
Sep 9, 2022
| if os.IsNotExist(err) { | ||
| logger.Warnf("skip not exist file or directory: %s", path) | ||
| return nil | ||
| } | ||
| listed <- nil | ||
| logger.Errorf("list %s: %s", path, err) | ||
| return err | ||
| return nil |
There was a problem hiding this comment.
if return nil , sync producer will quit loop, so here need return err to quit recursive walk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1588