Enable no-console rule

Logger should be used instead
juice-shop · Oct 11, 2024 · bf3a770 · bf3a770
1 parent a0064c0
commit bf3a770
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/juice-balancer/eslint.config.js b/juice-balancer/eslint.config.js
@@ -19,7 +19,7 @@ export default [
       'prettier/prettier': 'error',
       'linebreak-style': ['error', 'unix'],
       semi: ['error', 'always'],
-      'no-console': 'off',
+      'no-console': 'error',
     },
   },
   js.configs.recommended,

diff --git a/juice-balancer/src/app.js b/juice-balancer/src/app.js
@@ -7,6 +7,7 @@ import basicAuth from 'basic-auth-connect';
 import onFinished from 'on-finished';
 
 import { get } from './config.js';
+import { logger } from './logger.js';
 
 import { createTeamsRouteHandler } from './teams/teams.js';
 import { createAdminRouteHandler } from './admin/admin.js';
@@ -43,7 +44,7 @@ export function createApp({ kubernetesApi, proxy }) {
           res.set('Content-Type', register.contentType);
           res.end(await register.metrics());
         } catch (err) {
-          console.error('Failed to write metrics', err);
+          logger.warn('Failed to write metrics', err);
           res.status(500).end();
         }
       }