Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix example: sklearn cross_validation module EOL #128

Merged
merged 1 commit into from
Oct 19, 2018

Conversation

shiodat
Copy link
Contributor

@shiodat shiodat commented Oct 4, 2018

The sklearn.cross_validation module is EOL in sklearn 0.20, which is now stable.
The classifier_kfold.py example uses it and I fixed it to use sklearn.model_selection module.

@coveralls
Copy link

coveralls commented Oct 4, 2018

Coverage Status

Coverage remained the same at 88.032% when pulling 32e432b on fix-sklearn-eol-functions into 70d920b on develop.

@shiodat shiodat force-pushed the fix-sklearn-eol-functions branch from d1fc563 to 32e432b Compare October 4, 2018 01:35
@rimms rimms self-assigned this Oct 15, 2018
@rimms
Copy link
Member

rimms commented Oct 19, 2018

👍 LGTM

  • scikit-learn 0.17.1

    $ pip freeze | grep scikit-learn
    scikit-learn==0.17.1
    $ coverage run -p tools/run_examples.py
    
      .. snip ..
    
    --- classifier_kfold.py -----------------------------
    
      .. snip ..
    
      virginica       1.00      0.02      0.04        50
    
    avg / total       0.84      0.67      0.57       150
    
  • scikit-learn 0.20.0

    $ pip freeze | grep scikit-learn
    scikit-learn==0.20.0
    $ coverage run -p tools/run_examples.py
      .. snip ..
    
    --- classifier_kfold.py -----------------------------
    
      .. snip ..
    
       virginica       1.00      0.24      0.39        50
    
       micro avg       0.75      0.75      0.75       150
       macro avg       0.86      0.75      0.70       150
    weighted avg       0.86      0.75      0.70       150
    

@rimms rimms merged commit 8096681 into develop Oct 19, 2018
@rimms rimms deleted the fix-sklearn-eol-functions branch October 19, 2018 01:27
@rimms rimms added this to the 0.6.1 milestone Oct 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants