readthedown CSS tidy up #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Already has padding set on Ln777 and this second one looks to be invalid w/ em - px.
Sidebar has both display inline-block (ln 806) and display block. Looks like display-block is what is actually in effect currently in browsers I checked.
#sidebar header had both display and display-inline.
Removed one of two color = white from .wy-alert-title,#content .admonition-title
|
Merged. Thanks for the pull request ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
None of these are important and the diff should have no functional impact. They are just clean up suggestions. Most of the diff is just in removing code that had all be commented out. The lines which were not commented out were all some version of duplicated directive within a single selector.
For the two selectors that had both
display:inline-block;anddisplay:block;within them I pickeddisplay:inline-block;because that was the active rule when I checked in dev tools in FF and Chrome. That said I couldn't find any clear spec for what is supposed to happen when a directive is redeclared within a selector so I am not 100% sure that this edit is a silent change in all rendering engines.