Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible unused lightbox dependency footprint included in readthedown when lightbox = false #128

Closed
sciatro opened this issue Feb 27, 2022 · 2 comments
Closed

Possible unused lightbox dependency footprint included in readthedown when lightbox = false #128

sciatro opened this issue Feb 27, 2022 · 2 comments

Comments

@sciatro
Copy link
Contributor

sciatro commented Feb 27, 2022

When using rmdformats::readthedown with:

    lightbox: false
    thumbnails: false

I see the the js / css for magnific-popup in the <head> of my final knitted html, e.g. with self_contained: false:

        <link href="libs/magnific-popup-1.1.0/magnific-popup.css" rel="stylesheet" />
        <script src="libs/magnific-popup-1.1.0/jquery.magnific-popup.min.js"></script>

After a little bit of time poking around in the final knitted page with browser dev tools I am not seeing obvious examples of either in use. On the other end when I manually remove them the overall effect of the final page appears preserved.

My front end knowledge is minimal at best so all of this is wholly theory-free poking around but, is it possible that these dependencies are included on accident even when lightbox is false?
juba added a commit that referenced this issue Feb 27, 2022
@juba
Don't add magnific_popup dependency if lightbox is false (#128)
2f96d66
@juba
Copy link
Owner

juba commented Feb 27, 2022

Indeed, you're right, the magnific popup dependency was added systematically. This should now be fixed in the development version, magnific popup should not be included anymore if lightbox: false.

Thanks !

@juba juba closed this as completed Feb 27, 2022
@sciatro sciatro mentioned this issue Feb 27, 2022
Closed
@sciatro
Copy link
Contributor Author

sciatro commented Feb 27, 2022

Thank you for looking into it and all of the hard work on this package.

@sciatro sciatro mentioned this issue Feb 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@juba @sciatro