Proposal: Better routing management #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kradalby
previously approved these changes
Nov 21, 2022
|
|
||
| ```go | ||
| type Route struct { | ||
| ID uint64 `gorm:"primary_key"` |
There was a problem hiding this comment.
This is very sidenote, but we can probably stop defining a bunch of these fields and inherit them: https://gorm.io/docs/models.html#gorm-Model
juanfont
force-pushed
the
better-routes-proposal
branch
from
c228221 to
59be63f
Compare
kradalby
approved these changes
Nov 21, 2022
This was referenced Nov 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a proposal to improve how we handle the routing and subnet routers.