Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not allow preauth keys to be deleted if assigned to node #2396

Merged
merged 2 commits into from
Feb 1, 2025

Conversation

kradalby
Copy link
Collaborator

@kradalby kradalby commented Jan 31, 2025

we need to be able to look up the tags on the key, never delete, only expire if in use. There is no API for deleting, but never know if people edit the database.

@kradalby kradalby requested a review from juanfont as a code owner January 31, 2025 16:43
Signed-off-by: Kristoffer Dalby <[email protected]>
@kradalby kradalby merged commit 9bd1438 into juanfont:main Feb 1, 2025
133 of 137 checks passed
@nblock nblock added this to the v0.25.0 milestone Feb 1, 2025
kradalby added a commit to kradalby/headscale that referenced this pull request Feb 7, 2025
…#2396)

* do not allow preauth keys to be deleted if assigned to node

Signed-off-by: Kristoffer Dalby <[email protected]>

* update changelog

Signed-off-by: Kristoffer Dalby <[email protected]>

---------

Signed-off-by: Kristoffer Dalby <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants