Spell check and updating docs #2380
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nbelles
requested review from
ohdearaugustin,
nblock,
juanfont and
kradalby
as code owners
nblock
requested changes
Jan 26, 2025
nblock
requested changes
Jan 27, 2025
| @@ -1840,7 +1840,7 @@ func TestPolicyBrokenConfigCommand(t *testing.T) { | |||
| { | |||
| // This is an unknown action, so it will return an error | |||
| // and the config will not be applied. | |||
| Action: "acccept", | |||
| Action: "accept", | |||
There was a problem hiding this comment.
The comment above explicitly mentions an "unknown action", please revert this change.
There was a problem hiding this comment.
Would it be reasonable to change this for something that isn't explicitly a typo? Maybe something that makes more logical sense for it to not be valid while still passing a spell check search?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a slight inconsistency in the public docs (the
/windowsand/applepages were referenced but not/android) and I figured while I was making this PR that I might as well do a quick spell check across the codebase. Most everything was updating spelling in comments.There is one actual code change in an integration test (
/integration/cli_test.go) that had a string that had a typo in it. That is probably the only thing that could use a pair of eyes from an actual codebase developer to make sure that doesn't break anything.Thanks!