-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move flags after the command #2100
Conversation
The built-in help also shows flags to given after the command. Align documentation examples accordingly.
WalkthroughThe documentation for the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Headscale
User->>Headscale: Register Node
Headscale-->>User: Confirmation
User->>Headscale: Create Pre-authenticated Key
Headscale-->>User: Key Created
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (5)
- docs/running-headscale-container.md (2 hunks)
- docs/running-headscale-linux-manual.md (1 hunks)
- docs/running-headscale-linux.md (1 hunks)
- docs/running-headscale-openbsd.md (1 hunks)
- docs/running-headscale-sealos.md (1 hunks)
Files skipped from review due to trivial changes (1)
- docs/running-headscale-container.md
Additional context used
Markdownlint
docs/running-headscale-sealos.md
51-51: Expected: indented; Actual: fenced
Code block style(MD046, code-block-style)
docs/running-headscale-openbsd.md
139-139: Expected: indented; Actual: fenced
Code block style(MD046, code-block-style)
docs/running-headscale-linux-manual.md
102-102: Expected: indented; Actual: fenced
Code block style(MD046, code-block-style)
Additional comments not posted (8)
docs/running-headscale-linux.md (2)
81-81
: LGTM!The change to the command syntax for registering a machine looks good. Moving the
--user
flag after thenodes register
command aligns the syntax with the built-in help feature and improves clarity.
89-89
: LGTM!The change to the command syntax for generating a pre-authenticated key looks good. Moving the
--user
flag after thepreauthkeys create
command aligns the syntax with the built-in help feature and improves clarity.docs/running-headscale-sealos.md (2)
44-44
: LGTM!The code changes are approved. The updated command syntax simplifies the command and improves clarity by removing the redundant
headscale
prefix and repositioning the--user
flag after the command. This change aligns the documentation examples with the built-in help.
52-52
: LGTM!The code changes are approved. The updated command syntax simplifies the command and improves clarity by removing the redundant
headscale
prefix and repositioning the--user
flag after the command. This change aligns the documentation examples with the built-in help.docs/running-headscale-openbsd.md (2)
132-132
: LGTM!The change to the command syntax for registering a machine looks good. Moving the
--user
flag after thenodes register
subcommand aligns with the project's built-in help feature and improves clarity. The functionality remains intact.
140-140
: Looks good!Moving the
--user
flag after thepreauthkeys create
subcommand is consistent with the project's built-in help feature and enhances the clarity of the command. The functionality is preserved.docs/running-headscale-linux-manual.md (2)
95-95
: The change to the command for registering a machine looks good.Removing the redundant
headscale
prefix and repositioning the--user
flag simplifies the command syntax and improves the clarity of the documentation without altering the functionality.
103-103
: The change to the command for generating a pre-authenticated key looks good.Removing the redundant
headscale
prefix and repositioning the--user
flag simplifies the command syntax and improves the clarity of the documentation without altering the functionality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
neat!
The built-in help also shows flags to given after the command. Align documentation examples accordingly.
Summary by CodeRabbit
headscale
documentation, enhancing clarity and usability.headscale
prefix in command examples, aligning with common command-line conventions.