Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for non-noise clients (pre-1.32) #1611

Merged
merged 10 commits into from
Nov 23, 2023

Conversation

kradalby
Copy link
Collaborator

@kradalby kradalby commented Nov 19, 2023

The goal of this PR is to drop client versions older than 1.32 (over one year old), to allow us to remove a lot of legacy code and only support one protocol.

It will also allow us to use modern MapRequest features and not have us maintain a lot of duplicate code/functionality.

@kradalby kradalby force-pushed the deprecate-old-versions branch 4 times, most recently from 6a9a981 to 9ba6582 Compare November 19, 2023 22:18
@kradalby kradalby changed the title disable tests for unsupported versions Remove support for non-noise clients (pre-1.32) Nov 20, 2023
@kradalby kradalby marked this pull request as ready for review November 20, 2023 19:45
@kradalby kradalby requested a review from juanfont as a code owner November 20, 2023 19:45
Signed-off-by: Kristoffer Dalby <[email protected]>
Signed-off-by: Kristoffer Dalby <[email protected]>
Signed-off-by: Kristoffer Dalby <[email protected]>
Signed-off-by: Kristoffer Dalby <[email protected]>
Signed-off-by: Kristoffer Dalby <[email protected]>
Signed-off-by: Kristoffer Dalby <[email protected]>
Signed-off-by: Kristoffer Dalby <[email protected]>
@kradalby kradalby force-pushed the deprecate-old-versions branch from e25247b to 2900d99 Compare November 21, 2023 17:22
Signed-off-by: Kristoffer Dalby <[email protected]>
@kradalby kradalby merged commit a59aab2 into juanfont:main Nov 23, 2023
44 checks passed
@dragon2611 dragon2611 mentioned this pull request Aug 22, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants