-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance pipeline stability and automatically retry unstable tests #1566
Conversation
@kradalby, can you take a look? |
Apologise, missed this one, I had it in my todo list to do something like this, but I think 50 is a bit excessive, how about we start with 5. The goal needs to be to get the tests to a state where that (or less) is the upper threshold. |
da8e69c
to
d3b9652
Compare
@kradalby , done, I changed it to 5. |
with: | ||
attempt_limit: 5 | ||
command: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this removes a bit too much?
with: | |
attempt_limit: 5 | |
command: | | |
with: | |
attempt_limit: 5 | |
command: | | |
nix develop --command -- docker run \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, sorry for that, I didn't check the changes after rebasing to main
, now it's fixed.
d3b9652
to
cdda856
Compare
2868b1e
to
06d2169
Compare
Hello there,
This Pull Request aims to introduce changes designed to enhance the overall stability of the pipeline and implement an automatic retry mechanism for tests that are currently unstable.
There is example, pipeline with retry: vsychov#2
There is pipeline without retry: #1562
Both of them contains same headscale file changes.
Another way to do that, is use
--rerun-fails
and--rerun-fails-max-failures
arguments ofgotestsum
.