Rename Machine to Node #1553
Merged
Rename Machine to Node #1553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 22, 2023
juanfont
force-pushed
the
machine-to-node-2
branch
from
b602cdd to
22585dc
Compare
kradalby
approved these changes
Sep 24, 2023
|
|
||
| // If the Machine table has a column for registered, | ||
| // If the MacNodehine table has a column for registered, |
routerino
pushed a commit
to gurucomputing/headscale-ui
that referenced
this pull request
Sep 29, 2023
* Rename machine to node in api According to juanfont/headscale#1553 * more fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Almost three years ago I made the mistake of calling Machines to the Tailscale clients in Headscale.
Since then it has become very obvious that they should be referred as Nodes.
This massive PR fixes that mistake across the codebase.