Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Previous binaries are not working with flutter_rust_bridge: 1.82.0 #36

Closed
gmpassos opened this issue Sep 29, 2023 · 8 comments
Closed

Comments

@gmpassos
Copy link

First of all, thank you for this package!

The dependency needs to be updated to the latest version, and the release binaries also need to be updated.

flutter_rust_bridge: ^1.72.2

I'm using wasm_run to provide Wasm runtime support in my package ApolloVM.

Best regards.

@juancastillo0
Copy link
Owner

juancastillo0 commented Oct 3, 2023

Hi thanks for the issue!

I am working on it. In the mena time, does pinning the version to flutter_rust_bridge : 1.72.2 as an override work? I think the problem is a breaking change in flutter_rust_bridge

@gmpassos
Copy link
Author

gmpassos commented Oct 3, 2023

Hi thanks for the issue!

I am working on it. In the mena time, does pinning the version to flutter_rust_bridge : 1.72.2 as an override work? I think the problem is a breaking change in flutter_rust_bridge

Pinning the version doesn't fix it, I have tried all the versions from 1.72.2. The previous compiled code can't work with flutter_rust_bridge, I managed to load the dynamic library but when making a call it checks some native method signature and fails.

I think that it's very simple to update this. If you publish/release an updated version I can finalize the wasm_run integration and test your package.

@gmpassos
Copy link
Author

gmpassos commented Oct 3, 2023

I already have implemented the integration, but I can't test it.

https://github.com/ApolloVM/apollovm_dart/blob/wasm-runtime-io/lib/src/languages/wasm/wasm_runtime_io.dart

@gmpassos
Copy link
Author

gmpassos commented Oct 3, 2023

If you want, I can help to make a transparent load and path resolution of the library binaries.

Take a look at:

https://github.com/gmpassos/dart_randomx/blob/master/lib/src/dart_randomx_base.dart#L71

@juancastillo0
Copy link
Owner

If you want, I can help to make a transparent load and path resolution of the library binaries.

Thanks I will take a look!

A new version wasm_run: ^0.0.1+2 has been release with a restriction flutter_rust_bridge: ">=1.72.2 <1.80.0" which does not have the breaking change. I believe this should fix it for now.

I will be uploading wasm_run: 0.1.0 with support for flutter_rust_bridge: ">=1.80.0" in the following days

@gmpassos
Copy link
Author

gmpassos commented Oct 9, 2023

Thanks for the update!

Now it's working. My tests are working now!

@gmpassos
Copy link
Author

gmpassos commented Oct 9, 2023

The only issue now is with a function that returns void:

void empty() {
            
}

Since isVoidReturn is not exposed, I can't check the returned Object by wasm_run. A void Function should return null in my framework.

@juancastillo0
Copy link
Owner

Thanks again for the issue, I will keep track of the other problems in the other issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants