fix(chordsv2): remove old code causing dup activations

keyberon/src/chord.rs

@@ -368,20 +368,6 @@ impl<'a, T> ChordsV2<'a, T> {
                 chord_candidates.retain(|chc| chc.participating_keys.contains(&press));
                 for chc in chord_candidates.iter() {
                     min_timeout = std::cmp::min(min_timeout, chc.pending_duration);
-                    if chc.pending_duration <= since
-                        && chc
-                            .participating_keys
-                            .iter()
-                            .all(|pk| accumulated_presses.contains(pk))
-                    {
-                        // Invariant:
-                        // This should only happen at most once per iteration
-                        // due to needing an exact match with accumulated presses.
-                        // Later iterations are "better" choices
-                        // if more than one timed_out_chord is found,
-                        // because they consume more presses.
-                        timed_out_chord = Some((chc, accumulated_presses.len() as u8));
-                    }
                 }
                 chord_candidates.len()
             } else {
@@ -523,13 +509,6 @@ impl<'a, T> ChordsV2<'a, T> {
             }
         }
 
-        if let Some((chord, consumed_presses)) = timed_out_chord {
-            self.queue.drain(0..usize::from(consumed_presses));
-            let ach = get_active_chord(chord, since, self.next_coord(), relevant_release_found);
-            let overflow = self.active_chords.push(ach);
-            assert!(overflow.is_ok(), "active chords has room");
-        }
-
         // Clear presses from the queue if they were consumed by a chord.
         if self.active_chords.len() > prev_active_chords_len {
             self.queue.retain(|qd| match qd.event {

src/tests/sim_tests/chord_sim_tests.rs

@@ -403,3 +403,30 @@ fn sim_chord_oneshot() {
         result
     );
 }
+
+#[test]
+fn sim_chord_timeout_events() {
+    let result = simulate(
+        "
+(defcfg
+ concurrent-tap-hold yes
+ process-unmapped-keys yes
+)
+(defvirtualkeys
+ v-macro-word-end (macro spc)
+)
+(defsrc a b c)
+(defchordsv2-experimental
+ (a b c) (macro x y z (on-press tap-vkey v-macro-word-end)) 200 all-released ()
+ (a b) (macro x y (on-press tap-vkey v-macro-word-end)) 200 all-released ()
+)
+(deflayer base a b c)
+        ",
+        "d:a t:10 d:b t:3000 u:a u:b t:100",
+    )
+    .to_ascii();
+    assert_eq!(
+        "t:201ms dn:X t:1ms up:X t:1ms dn:Y t:1ms up:Y t:4ms dn:Space t:1ms up:Space",
+        result
+    );
+}