Merge pull request #16 from jtiala/refactor-configs

Refactor eslint and typescript configs
jtiala · Sep 30, 2023 · adf6be6 · adf6be6
2 parents 95f3ac2 + c5ad2da
commit adf6be6
Show file tree

Hide file tree

Showing 17 changed files with 765 additions and 47 deletions.
diff --git a/apps/react-example/.eslintrc.json b/apps/react-example/.eslintrc.json
@@ -1,6 +1,6 @@
 {
   "root": true,
-  "extends": ["@themeless-ui/eslint-config/vite.json"],
+  "extends": ["@themeless-ui/eslint-config/react.json"],
   "env": {
     "browser": true,
     "es2022": true

diff --git a/apps/react-example/tsconfig.json b/apps/react-example/tsconfig.json
@@ -1,5 +1,5 @@
 {
-  "extends": "@themeless-ui/typescript-config/vite.json",
+  "extends": "@themeless-ui/typescript-config/vite-react.json",
   "include": ["src"],
   "exclude": ["src/**/*.test.{ts,tsx}"]
 }
diff --git a/packages/eslint-config/vite.json → packages/eslint-config/react.json b/packages/eslint-config/vite.json → packages/eslint-config/react.json
diff --git a/packages/react/.eslintrc.json b/packages/react/.eslintrc.json
@@ -1,6 +1,6 @@
 {
   "root": true,
-  "extends": ["@themeless-ui/eslint-config/vite.json"],
+  "extends": ["@themeless-ui/eslint-config/react.json"],
   "env": {
     "browser": true,
     "es2022": true

diff --git a/packages/react/tsconfig.json b/packages/react/tsconfig.json
@@ -1,5 +1,5 @@
 {
-  "extends": "@themeless-ui/typescript-config/vite.json",
+  "extends": "@themeless-ui/typescript-config/vite-react.json",
   "include": ["src"],
   "exclude": ["src/**/*.test.{ts,tsx}"]
 }
diff --git a/packages/style/.eslintrc.json b/packages/style/.eslintrc.json
@@ -1,6 +1,6 @@
 {
   "root": true,
-  "extends": ["@themeless-ui/eslint-config/vite.json"],
+  "extends": ["@themeless-ui/eslint-config/react.json"],
   "env": {
     "browser": true,
     "es2022": true

diff --git a/packages/style/tsconfig.json b/packages/style/tsconfig.json
@@ -1,4 +1,4 @@
 {
-  "extends": "@themeless-ui/typescript-config/vite.json",
+  "extends": "@themeless-ui/typescript-config/vite-react.json",
   "include": ["src"]
 }
diff --git a/packages/theme-default/.eslintrc.json b/packages/theme-default/.eslintrc.json
@@ -1,6 +1,6 @@
 {
   "root": true,
-  "extends": ["@themeless-ui/eslint-config/vite.json"],
+  "extends": ["@themeless-ui/eslint-config/react.json"],
   "env": {
     "browser": true,
     "es2022": true

diff --git a/packages/theme-default/tsconfig.json b/packages/theme-default/tsconfig.json
@@ -1,4 +1,4 @@
 {
-  "extends": "@themeless-ui/typescript-config/vite.json",
+  "extends": "@themeless-ui/typescript-config/vite-react.json",
   "include": ["src"]
 }
diff --git a/packages/typescript-config/base.json b/packages/typescript-config/base.json
@@ -1,16 +1,14 @@
 {
   "$schema": "https://json.schemastore.org/tsconfig",
   "compilerOptions": {
-    "composite": false,
-    "declaration": true,
-    "declarationMap": true,
     "esModuleInterop": true,
     "forceConsistentCasingInFileNames": true,
-    "inlineSources": false,
+    "incremental": true,
     "isolatedModules": true,
-    "moduleResolution": "node",
-    "noUnusedLocals": false,
-    "noUnusedParameters": false,
+    "moduleResolution": "Node",
+    "noImplicitReturns": true,
+    "noUnusedLocals": true,
+    "noUnusedParameters": true,
     "preserveWatchOutput": true,
     "skipLibCheck": true,
     "strict": true

diff --git a/packages/typescript-config/nextjs.json b/packages/typescript-config/nextjs.json
@@ -3,11 +3,10 @@
   "extends": "./base.json",
   "compilerOptions": {
     "allowJs": true,
-    "incremental": true,
     "jsx": "preserve",
     "lib": ["DOM", "DOM.iterable", "ESNext"],
     "module": "ESNext",
-    "moduleResolution": "bundler",
+    "moduleResolution": "Bundler",
     "noEmit": true,
     "paths": {
       "@/*": ["./*"]

diff --git a/packages/typescript-config/package.json b/packages/typescript-config/package.json
@@ -23,5 +23,8 @@
   "packageManager": "[email protected]",
   "scripts": {
     "publish:npm": "pnpm publish --access public"
+  },
+  "devDependencies": {
+    "ts-lit-plugin": "1.2.1"
   }
 }
diff --git a/packages/typescript-config/vite-lit.json b/packages/typescript-config/vite-lit.json
@@ -0,0 +1,18 @@
+{
+  "$schema": "https://json.schemastore.org/tsconfig",
+  "extends": "./base.json",
+  "compilerOptions": {
+    "allowSyntheticDefaultImports": true,
+    "experimentalDecorators": true,
+    "lib": ["ESNext", "DOM", "DOM.Iterable"],
+    "module": "ESNext",
+    "noEmit": true,
+    "plugins": [
+      {
+        "name": "ts-lit-plugin"
+      }
+    ],
+    "sourceMap": true,
+    "target": "ES2019"
+  }
+}
diff --git a/packages/typescript-config/vite.json → packages/typescript-config/vite-react.json b/packages/typescript-config/vite.json → packages/typescript-config/vite-react.json
@@ -6,12 +6,8 @@
     "lib": ["ESNext", "DOM"],
     "module": "ESNext",
     "noEmit": true,
-    "noImplicitReturns": true,
-    "noUnusedLocals": true,
-    "noUnusedParameters": true,
     "resolveJsonModule": true,
     "sourceMap": true,
-    "target": "ESNext",
-    "useDefineForClassFields": true
+    "target": "ESNext"
   }
 }
diff --git a/packages/utils/.eslintrc.json b/packages/utils/.eslintrc.json
@@ -1,6 +1,6 @@
 {
   "root": true,
-  "extends": ["@themeless-ui/eslint-config/vite.json"],
+  "extends": ["@themeless-ui/eslint-config/react.json"],
   "env": {
     "browser": true,
     "es2022": true

diff --git a/packages/utils/tsconfig.json b/packages/utils/tsconfig.json
@@ -1,5 +1,5 @@
 {
-  "extends": "@themeless-ui/typescript-config/vite.json",
+  "extends": "@themeless-ui/typescript-config/vite-react.json",
   "include": ["src"],
   "exclude": ["src/**/*.test.{ts,tsx}"]
 }