Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hugepages support for LCOW #104

Merged

Conversation

ninzavivek
Copy link

@ninzavivek ninzavivek commented Aug 17, 2021

Changes add support specifying hugepages mount in a LCOW spec on CRI side.

Hcsshim side of the changes are being tracked by following PR.

microsoft/hcsshim#1118

@ninzavivek ninzavivek changed the title hugepages handling Hugepages support for LCOW Aug 18, 2021
@ninzavivek ninzavivek marked this pull request as ready for review August 18, 2021 21:17
Signed-off-by: Vivek Aggarwal <[email protected]>
@ninzavivek ninzavivek force-pushed the vivek_hugepages_mount branch from 5c9a152 to 979a403 Compare August 30, 2021 23:34
Copy link

@dcantah dcantah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

@katiewasnothere katiewasnothere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@katiewasnothere katiewasnothere merged commit c738ca4 into jterry75:windows_port Sep 7, 2021
ambarve added a commit to ambarve/cri that referenced this pull request Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants