Add json test from #1206 #1270
Merged
Add json test from #1206 #1270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmccann
reviewed
Jan 3, 2025
benmccann
reviewed
Jan 3, 2025
|
|
||
| Table table = new JsonReader().read(Source.fromString(json)); | ||
|
|
||
| assertEquals(header, table.columnNames(), "Column order not preserved"); |
There was a problem hiding this comment.
a bug could make them unequal for other reasons. The test name already tells us what we're testing
Suggested change
| assertEquals(header, table.columnNames(), "Column order not preserved"); | |
| assertEquals(header, table.columnNames()); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing.
Description
Test case in PR #1206 description added as a unit test
Testing
Yes