Use jstransformer-scss and node-sass #4

RobLoach · 2015-07-19T22:39:14Z

Build upon jstransformer-scss, brings in Boilerplate for updated metadata.

Fixes #1.

This adds the inputFormats key to the boilerplate, allowing transformers to define what the expect input is: https://github.com/jstransformers/jstransformer#inputformats

feat(inputFormats): Add inputFormats

Switch LICENSE to markdown

This will make npm only deploy index.js and LICENSE.md.

Add files to package.json

Update and rename History.md to HISTORY.md

I believe it includes all `*.md` files automatically for us.

Remove "LICENSE.md" from "files" in package.json

Add some things

Add links in the documentation

``` Output: "<span class="foo" id='bar'>hello world</span>\n" Expected: "<span class="foo" id='bar'>hello world</span>" ✓ escape-html.render() (11ms) ``` While the tests pass, there's an extra \n at the end of output console log. Having the input to assertEqual() there will fix it.

Add compileFile() test

Disable email notifications

Fix tests to trim the output

Add compileFileAsync() test

https://github.com/orgs/jstransformers/people

RobLoach · 2015-08-05T16:19:17Z

@ForbesLindesay

Did this break the old test cases?

Probably... We should look through the tests and ensure the implementations are still there.

I think the scss module is native

To my knowledge, the sass package (which is what jstransformer-sass currently uses) is deprecated. It...

Lacks features from SASS and libsass
Was put together by tj years ago; don't think anyone is willing to keep it going
Has better implementations of a native JavaScript SASS-like in other systems like rework or postcss
Confuses people as when people use "sass", they expect SASS... Not an incomplete implementation of it.

tunnckoCore · 2015-08-05T16:41:06Z

I dont see the problem? Let's merge.

Im just confused about this SASS/SCSS-ish things. Actually the good packages is called node-sass, but it actually accept only scss syntax by default, and sass with indentedSyntax:true option.. that's .. nah.. "God bless good coders and their minds!"

RobLoach · 2015-08-05T17:03:13Z

I dont see the problem? Let's merge.

We should replicate the currently existing test into a new folder, so rather than replacing it, we keep the existing one alive and well.

Im just confused about this SASS/SCSS-ish things

SASS is the language. The file extension convention is usually .sass which indicates indentSyntax:true with the whitespace and .scss is Sassy-CSS, without the indentation.

RobLoach · 2015-08-05T17:35:20Z

test/table/input.sass

  :font-size 15px
-+striped
+=striped
  tr
    :background #fff
    +large


The original test is now at test/table/input.sass. Mixins are declared by using =, they are used via +:
http://sass-lang.com/guide#topic-6

Moved Boilerplate documentation to the Wiki

`npm` sometimes fixes the scripts to be alphabetized. This will avoid that change in the future.

Fix sort order of scripts

Does this work yet?

Add Node.js 4.0.0 to Travis testing

Anyone using io.js should be on node 4.0.0 by now.

Remove io.js from testing

Add 'engines' spec into package.json

RobLoach · 2015-10-15T19:48:39Z

The tests have been updated accordingly. Any thoughts?

https://github.com/nodejs/node/blob/v5.0.0/CHANGELOG.md

Add NodeJS 5.0.0 to the testing list

…pdate

TimothyGu and others added 30 commits April 2, 2015 21:12

Initial commit

554e3e2

Update README

5f7e394

Remove coveralls from devDependencies

453fe4a

Fixes #1.

feat(inputFormats): Add inputFormats

828ad46

This adds the inputFormats key to the boilerplate, allowing transformers to define what the expect input is: https://github.com/jstransformers/jstransformer#inputformats

Merge pull request #3 from jstransformers/inputformats

b4f17b2

feat(inputFormats): Add inputFormats

docs(license): Switch LICENSE to markdown

3359a5a

Merge pull request #4 from jstransformers/license-md

a5af279

Switch LICENSE to markdown

fix(files): Add files to package.json

bb9e002

This will make npm only deploy index.js and LICENSE.md.

Merge pull request #5 from jstransformers/package-files

e441053

Add files to package.json

Update and rename History.md to HISTORY.md

cf4bd57

Merge pull request #8 from jstransformers/history

150b87b

Update and rename History.md to HISTORY.md

fix(files): Remove "LICENSE.md" from "files"

da3d5d9

I believe it includes all `*.md` files automatically for us.

Merge pull request #9 from jstransformers/remove-license

d4d981a

Remove "LICENSE.md" from "files" in package.json

Add some things

7422bf0

Fix if statement wrapper, and add async functions

c2ceca6

Merge pull request #11 from jstransformers/things

759c792

Add some things

Add links in the documentation

bd4760b

Disable email notifications

a187d0b

Add Dependencies badge

5e52ebf

Merge pull request #12 from jstransformers/datlinktho

5781dfc

Add links in the documentation

Send notification email only on failure

5134186

Add compileFile() test

4cb1cc7

Add compileFileAsync() test

40c02ae

Fix the copyright to reference the JSTransformers Team

2695ec9

Merge pull request #17 from jstransformers/compileFile

35af0d5

Add compileFile() test

Merge pull request #13 from jstransformers/email

2ed2b34

Disable email notifications

Merge pull request #15 from jstransformers/trim

9d81fac

Fix tests to trim the output

Merge pull request #18 from jstransformers/compileFileAsync

cf222d6

Add compileFileAsync() test

Update License.md to JSTransformers Team

ddf5986

https://github.com/orgs/jstransformers/people

RobLoach mentioned this pull request Aug 5, 2015

Indented Sass jstransformers/jstransformer-scss#3

Closed

tunnckoCore mentioned this pull request Aug 5, 2015

node sass support #5

Closed

Add original table test

029e52f

RobLoach reviewed Aug 5, 2015
View reviewed changes

RobLoach and others added 12 commits August 12, 2015 23:14

Merge pull request #28 from jstransformers/wikisquashed

112a231

Moved Boilerplate documentation to the Wiki

Fix sort order of scripts

fa074b9

`npm` sometimes fixes the scripts to be alphabetized. This will avoid that change in the future.

Merge pull request #30 from jstransformers/scripts-sort

d76158e

Fix sort order of scripts

Allow changing indentedSyntax

c923ec9

Fix options being null

ad28d65

Add Node.js 4.0.0 to Travis testing

7cce151

Does this work yet?

Update node version specificity of "4"

ec2ab26

Merge pull request #31 from jstransformers/node4

f3737c1

Add Node.js 4.0.0 to Travis testing

Remove io.js from testing

3322834

Anyone using io.js should be on node 4.0.0 by now.

Merge pull request #32 from jstransformers/RobLoach-patch-1

a1c782e

Remove io.js from testing

Add 'engines' spec into package.json

0c90e07

Merge pull request #33 from jstransformers/engines

194bf4d

Add 'engines' spec into package.json

RobLoach and others added 4 commits October 30, 2015 02:13

Add NodeJS 5.0.0 to the testing list

537a7f3

https://github.com/nodejs/node/blob/v5.0.0/CHANGELOG.md

Merge pull request #34 from jstransformers/node-5

baf7091

Add NodeJS 5.0.0 to the testing list

Update .travis.yml

b01f25e

Update package.json

512a7ac

RobLoach changed the title ~~Update~~ Inherit from jstransformer-scss and node-sass Jun 6, 2016

Update to [email protected]

3e53417

RobLoach changed the title ~~Inherit from jstransformer-scss and node-sass~~ Use jstransformer-scss and node-sass Jun 6, 2016

Merge branch 'master' of github.com:jstransformers/boilerplate into u…

a624b38

…pdate

RobLoach merged commit ab7f8df into master Jun 6, 2016

RobLoach deleted the update branch June 6, 2016 15:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use jstransformer-scss and node-sass #4

Use jstransformer-scss and node-sass #4

RobLoach commented Jul 19, 2015 •

edited

Loading

RobLoach commented Aug 5, 2015

tunnckoCore commented Aug 5, 2015

RobLoach commented Aug 5, 2015

RobLoach Aug 5, 2015

RobLoach commented Oct 15, 2015

Use jstransformer-scss and node-sass #4

Use jstransformer-scss and node-sass #4

Conversation

RobLoach commented Jul 19, 2015 • edited Loading

RobLoach commented Aug 5, 2015

tunnckoCore commented Aug 5, 2015

RobLoach commented Aug 5, 2015

RobLoach Aug 5, 2015

Choose a reason for hiding this comment

RobLoach commented Oct 15, 2015

RobLoach commented Jul 19, 2015 •

edited

Loading