[components] Add element_ordering argument to PDFDocument #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstockwin
force-pushed
the
element-ordering
branch
from
819b9f4 to
9832d2c
Compare
jstockwin
force-pushed
the
element-ordering
branch
3 times, most recently
from
525a647 to
ee53777
Compare
jstockwin
force-pushed
the
element-ordering
branch
from
ee53777 to
60b3951
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
element_orderingto thePDFDocument. You can now specify an ordering function from the elements. You can choose from an enum of presets (left to right, top to bottom(default),right to left, top to bottom,top to bottom, left to right,top to bottom, right to left), or you can pass your own callable.This will be helpful for certain pdfs, for instance when creating sections (since these must be continuous sets of elements).
Linked issues
Closes #94
Testing
Tests have been added.
Checklist
docker-compose run --rm lint)CHANGELOG.md, following the format fromKeep a Changelog.