Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Section repr #90

Merged
merged 3 commits into from
May 22, 2020
Merged

Section repr #90

merged 3 commits into from
May 22, 2020

Conversation

paulopaixaoamaral
Copy link
Collaborator

@paulopaixaoamaral paulopaixaoamaral commented May 22, 2020 •
edited
Loading

Description

This adds a __len__ and __repr__ functions to the Section class.

Linked issues

Closes #63

Testing

Tests were added to the section tests that make sure that calling len() and repr() on a section will return the expected results.

Checklist

  • I have provided a good description of the change above
  • I have added any necessary tests
  • I have added all necessary type hints
  • I have checked my linting (docker-compose run --rm lint)
  • I have added/updated all necessary documentation
  • I have updated CHANGELOG.md, following the format from
    Keep a Changelog.

@paulopaixaoamaral paulopaixaoamaral marked this pull request as ready for review May 22, 2020 14:26
jstockwin
jstockwin approved these changes May 22, 2020
View reviewed changes
Copy link
Owner

@jstockwin jstockwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@paulopaixaoamaral paulopaixaoamaral merged commit 057a779 into master May 22, 2020
@paulopaixaoamaral paulopaixaoamaral deleted the section-repr branch May 22, 2020 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstockwin jstockwin jstockwin approved these changes

Assignees

@jstockwin jstockwin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add __repr__ to section class
2 participants
@paulopaixaoamaral @jstockwin