Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable advanced layout analysis #88

Merged
merged 2 commits into from
May 19, 2020
Merged

Conversation

paulopaixaoamaral
Copy link
Collaborator

@paulopaixaoamaral paulopaixaoamaral commented May 19, 2020

Description

Advanced layout analysis is not needed since we order text boxes ourselves, so we can disable it by default and hence improve the performance of the analysis.

Linked issues

Closes #50

Checklist

  • I have provided a good description of the change above
  • I have added any necessary tests
  • I have added all necessary type hints
  • I have checked my linting (docker-compose run --rm lint)
  • I have added/updated all necessary documentation
  • I have updated CHANGELOG.md, following the format from
    Keep a Changelog.

@pauloAmaral pauloAmaral force-pushed the disable-advanced-layout-analysis branch from 56d07a3 to 5383383 Compare May 19, 2020 12:16
Copy link
Owner

@jstockwin jstockwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jstockwin jstockwin merged commit 2750650 into master May 19, 2020
@jstockwin jstockwin deleted the disable-advanced-layout-analysis branch May 20, 2020 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[performance] Disable advanced layout analysis
2 participants