[visualise] Draw rectangular section outlines when possible #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstockwin
force-pushed
the
simple-visualisations
branch
from
26de271 to
c249b0f
Compare
pauloAmaral
suggested changes
May 14, 2020
Co-authored-by: pauloAmaral <[email protected]>
|
@pauloAmaral updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
First checks if we can draw a simple rectangle around a section (with increasingly smaller margins). If we can't (because there will always be an element that is NOT in the section that would be in the rectangle), then the old behaviour using Voronoi diagrams will be used. The Voronoi diagram is only computed when needed.
This change involved a bit of a refactor where more data is stored on the class, rather than passing it between lots of functions.
Linked issues
Closes #72
Testing
This is been tested on a few example PDFs locally. Unfortunately we cannot easily write tests for the visualise tool.
Checklist
docker-compose run --rm lint)CHANGELOG.md, following the format fromKeep a Changelog.