-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Add examples to documentation #74
Conversation
c5ff067
to
f3f2db7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice examples! I have a few comments but nothing big.
Also, do you think it would be too much to add a few screenshots of the PDFs in the first and second examples? I think it would help to understand what you're reading if you see the elements you are trying to extract data from (1st example) and creating the sections (2nd example) without having to go back and forth from docs and PDF. But no big deal, up to you!
Co-authored-by: pauloAmaral <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 🥳 🥳 🥳
Closes #48, and as a side effect closes #56.
I've temporarily published the version of the docs from this branch, to help with the review. You can view this here: https://py-pdf-parser.readthedocs.io/en/doc-examples/