Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add issue templates #70

Merged
merged 4 commits into from
May 4, 2020
Merged

Add issue templates #70

merged 4 commits into from
May 4, 2020

Conversation

jstockwin
Copy link
Owner

@jstockwin jstockwin commented Apr 30, 2020 •
edited
Loading

Closes #49

@jstockwin jstockwin requested a review from jean-garret April 30, 2020 14:18
jean-garret
jean-garret approved these changes May 1, 2020
View reviewed changes
Copy link
Collaborator

@jean-garret jean-garret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question, is it mentioned somewhere that we are using black and if someone submit a pull request the format should be accepted by black?

@jstockwin
Copy link
Owner Author

@jean-garret Good point, I've added a new commit

@jstockwin jstockwin requested a review from jean-garret May 1, 2020 11:59
@jstockwin jstockwin mentioned this pull request May 4, 2020
Merged
kawa-marcin
kawa-marcin approved these changes May 4, 2020
View reviewed changes
Copy link
Collaborator

@kawa-marcin kawa-marcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jstockwin jstockwin merged commit db527fa into master May 4, 2020
@jstockwin jstockwin deleted the github-meta branch May 4, 2020 14:22
@jstockwin jstockwin mentioned this pull request May 4, 2020
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kawa-marcin kawa-marcin kawa-marcin approved these changes

@jean-garret jean-garret Awaiting requested review from jean-garret

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add license, contributing, gh template, and changelog files
3 participants
@jstockwin @kawa-marcin @jean-garret