Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tests and docs from wheels #388

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Conversation

paulopaixaoamaral
Copy link
Collaborator

@paulopaixaoamaral paulopaixaoamaral commented Jul 23, 2024

Description

This change will remove tests and docs from binary distribution wheels (PyPi) and source distribution (sdist).

Linked issues

closes #383

Testing

Run python setup.py bdist_wheel and confirm the tests directory is excluded from the generated wheel.

Checklist

  • I have provided a good description of the change above
  • I have added any necessary tests
  • I have added all necessary type hints
  • I have checked my linting (docker-compose run --rm lint)
  • I have added/updated all necessary documentation
  • I have updated CHANGELOG.md, following the format from
    Keep a Changelog.

@paulopaixaoamaral paulopaixaoamaral self-assigned this Jul 23, 2024
@paulopaixaoamaral paulopaixaoamaral force-pushed the remove-tests-from-wheels branch 2 times, most recently from 891ae07 to d78670e Compare July 23, 2024 11:52
@paulopaixaoamaral paulopaixaoamaral changed the title Remove tests from wheels Remove tests and docs from wheels Jul 23, 2024
@paulopaixaoamaral paulopaixaoamaral force-pushed the remove-tests-from-wheels branch from d78670e to f633856 Compare July 23, 2024 11:52
Copy link
Owner

@jstockwin jstockwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jstockwin jstockwin merged commit 74eb751 into master Jul 23, 2024
4 checks passed
@jstockwin jstockwin deleted the remove-tests-from-wheels branch July 23, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Py PDF Parser tests are distributed in PyPi wheels
2 participants