Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[loaders] Only accept LTTextBoxes from pdfminer.six #155

Merged
merged 1 commit into from
Jan 15, 2021

Conversation

jstockwin
Copy link
Owner

@jstockwin jstockwin commented Jan 15, 2021

Description

Ensures only LTTextBoxes get through as our elements. See #154 for details.

Linked issues

Closes #154

Testing

I have tested this on my broken pdf, and CI tests should still pass.

Checklist

  • I have provided a good description of the change above
  • I have added any necessary tests
  • I have added all necessary type hints
  • I have checked my linting (docker-compose run --rm lint)
  • I have added/updated all necessary documentation
  • I have updated CHANGELOG.md, following the format from
    Keep a Changelog.

Copy link
Collaborator

@paulopaixaoamaral paulopaixaoamaral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jstockwin jstockwin merged commit fcb0c5c into master Jan 15, 2021
@jstockwin jstockwin deleted the lt-text-line-fix branch January 15, 2021 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[loaders] Loads accept LTTextLines as top level pdfminer elements, which breaks things
2 participants