Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[filtering] Add new move_forwards_from and move_backwards_from functions #113

Merged
merged 2 commits into from
Jul 9, 2020

Conversation

jstockwin
Copy link
Owner

Description

Discussion in #111. Essentially, it was difficult to move through an element list starting at a given element. This makes that process both easier, and (I think) more efficient.

Linked issues

Closes #111

Testing

CI tests have been added.

Checklist

  • I have provided a good description of the change above
  • I have added any necessary tests
  • I have added all necessary type hints
  • I have checked my linting (docker-compose run --rm lint)
  • I have added/updated all necessary documentation (The docs generated form the docstrings are good enough here)
  • I have updated CHANGELOG.md, following the format from
    Keep a Changelog.

Copy link
Collaborator

@paulopaixaoamaral paulopaixaoamaral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few issues only, but looks good in general!

py_pdf_parser/filtering.py Outdated Show resolved Hide resolved
py_pdf_parser/filtering.py Outdated Show resolved Hide resolved
py_pdf_parser/filtering.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@paulopaixaoamaral paulopaixaoamaral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jstockwin jstockwin merged commit 43c5a6a into master Jul 9, 2020
@jstockwin jstockwin deleted the next-and-prev branch July 9, 2020 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some suggestions to enhance locating logics -'offset()' and 'resize()'
2 participants