Don't run checks which assume a defined instance against undefined #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erayd
force-pushed
the
bugfix-566-not
branch
from
ef7592c to
26ed648
Compare
Validation tests for an undefined instance should be limited to those tests which are actually applicable (e.g. required, default). Tests which assume an instance previously attempted to validate an internal default when the instance is undefined, rather than ignoring it, which is incorrect behavior. Closes jsonrainbow#566.
erayd
force-pushed
the
bugfix-566-not
branch
from
26ed648 to
d28c613
Compare
|
@shmax Could you please review this when you have some time. |
Merged
erayd
added a commit
that referenced
this pull request
Sep 25, 2019
## Backported PRs * #559 ArraysTest for array items with enum validation * #567 Don't run checks which assume a defined instance against undefined * #575 Tests on PHP 7.3 * #587 Fixed PHPDoc of Validator::validate() method * #583 Fix travis PHP 5.4 and 5.5 config ## Additional PRs (5.x.x only) These PRs are only applicable to the 5.x.x branch, and have been merged individually. * #589 Update validate-json to use spl_autoload_register ## Skipped PRs * #464 marc-mabe/php-enum versions (dependency not present in 5.x.x)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds undefined check to the end of required clause.
Validation tests for an undefined instance should be limited to those
tests which are actually applicable (e.g. required, default). Tests
which assume an instance previously attempted to validate an internal
default when the instance is undefined, rather than ignoring it, which
is incorrect behavior.
Closes #566.