Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ES5 build to run test suite in nashorn #288

Merged
merged 1 commit into from
Dec 19, 2018
Merged

fix ES5 build to run test suite in nashorn #288

merged 1 commit into from
Dec 19, 2018

Conversation

andrew-coleman
Copy link
Member

@andrew-coleman andrew-coleman commented Dec 18, 2018

Changes made to the es5 build and polyfills to get jsonata-es5.js up to scratch for running the test suite in Java Nashorn. This is representative of a barebones ES5 implementation.
Most of the tests now run under nashorn with the exception of:

  • tests involving multibyte unicode strings (might need extra polyfills here)
  • case insensitive regexes (for some reason)
  • base64 encode/decode functions

resolves #287 (hopefully)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling fa84555 on nashorn into bdafec2 on master.

@mattbaileyuk mattbaileyuk merged commit c78a04d into master Dec 19, 2018
@mattbaileyuk mattbaileyuk deleted the nashorn branch December 19, 2018 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Angular 6, ES5, and IE11 issues
3 participants