-
-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tools Page Table mobile Adjustments #1473
base: main
Are you sure you want to change the base?
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1473 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 396 396
Branches 106 106
=========================================
Hits 396 396 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DhairyaMajmudar Yes, that's the intended design. It was also suggested in the issue, as keeping the headers would make it too dense, small, and hard to read. But we could add an example card with all the fields labeled by their names at the start, it might work better. i would like to hear your opinion on this |
Remvoing table header won't be a good idea as it will be difficult for user to know what fields are related to which tag, the changes which you're suggesting is also not so optimal as it will add and empty/dummy card. Pls. suggest some more ideas. |
What kind of change does this PR introduce?
This PR will adjust the tables on the tools page for mobile and improve the desktop table to prevent it from being cut off, ensuring users don't need to scroll sideways to view the full length of the table.
Issue Number:
Screenshots/videos:
Summary
I think this is a necessary change, as it will improve the readability of the tools on the page.
Does this PR introduce a breaking change?
no