Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Counter to dropdown menu in tools Page #1479

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add Counter to dropdown menu in tools Page #1479

wants to merge 6 commits into from
+42 −10

Conversation

AQIB-NAWAB
Copy link
Contributor

What kind of change does this PR introduce?

feature
Issue Number:

Screenshots/videos:

image

Summary
Add a counter to each dropdown which increase the user experience

Does this PR introduce a breaking change?
No

@AQIB-NAWAB AQIB-NAWAB requested a review from a team as a code owner March 8, 2025 19:30
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 8, 2025 •
edited
Loading

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 7c135be

@codecov Codecov
Copy link

codecov bot commented Mar 8, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (219521e) to head (7c135be).

Additional details and impacted files 
@@            Coverage Diff            @@
##              main     #1479   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          396       396           
  Branches       106       106           
=========================================
  Hits           396       396

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AQIB-NAWAB
Copy link
Contributor Author

Hi @benjagm , please review the PR

DhairyaMajmudar
DhairyaMajmudar requested changes Mar 10, 2025
View reviewed changes
Copy link
Member

@DhairyaMajmudar DhairyaMajmudar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AQIB-NAWAB Thanks for PR pls. check my review comments

@AQIB-NAWAB
Copy link
Contributor Author

@DhairyaMajmudar Please review the PR

@DhairyaMajmudar
Copy link
Member

The border around the number is not full circle

Screenshot from 2025-03-10 20-04-10

The changes are not optimal with light mode

image

@AQIB-NAWAB
Copy link
Contributor Author

AQIB-NAWAB commented Mar 10, 2025 •
edited
Loading

@DhairyaMajmudar is it good under light mode ??

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DhairyaMajmudar DhairyaMajmudar DhairyaMajmudar requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨ Enhancement: Display Selected Filter Count as Badges on Filter Dropdowns
2 participants
@AQIB-NAWAB @DhairyaMajmudar